Skip to content
This repository was archived by the owner on Mar 13, 2022. It is now read-only.

Migrate to pytest? #153

Closed
oz123 opened this issue Aug 15, 2019 · 6 comments
Closed

Migrate to pytest? #153

oz123 opened this issue Aug 15, 2019 · 6 comments
Assignees

Comments

@oz123
Copy link
Contributor

oz123 commented Aug 15, 2019

Currently, the test suite uses nose while the python-client uses pytest.
I suggest migrating the tests of this project to pytest too. This will ease contributions
to both projects.

@ellieayla
Copy link

It doesn't look like there's any nose-specific stuff going on here, it's all standard module unittest and nose is only being used as the test runner. pytest would be nearly a drop-in replacement, other than the coverage configuration. Does that match your understanding? Did you want to make a PR?

@oz123
Copy link
Contributor Author

oz123 commented Aug 20, 2019

@alanjcastonguay yes, I would like to make a PR for that.

@scottilee
Copy link

@oz123 any update on this? Do you want to assign the issue to yourself?

@oz123
Copy link
Contributor Author

oz123 commented Sep 26, 2019

/assign

I will submit this PR this weekend I hope.

@micw523
Copy link
Contributor

micw523 commented Oct 2, 2019

/close

@k8s-ci-robot
Copy link
Contributor

@micw523: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants