-
Notifications
You must be signed in to change notification settings - Fork 2k
Build with JDK 21 #2888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build with JDK 21 #2888
Conversation
|
Welcome @javanegmond! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: javanegmond The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I think it would be ok to take this as a separate branch, but we're not going to move to Java 21 on the mainline for now. Even if we move forward, we're going to move forward to Java 11 or Java 17 not Java 21. If you want to merge this into the mainline, the right option to move forward is to update the pom.xml to build two different versions of the library, not to replace the current version. @yue9944882 wdyt? |
Sounds absolutely fair to me. Java 11 still has good support from multiple providers until some time in 2024 IIRC.
All up to you guys. I just wanted to do a quick run of what effort is necessary to be able to build with Java 21, which turns out is not a lot, but it's not a freebie either. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Closing this as we have moved to a different plan to move forward to JDK11 |
As outlined in #2886, here's a change that will build and pass all tests except e2e tests. I've not had time to run e2e tests, but they compile.
Note that this very eagerly changes all locations where a java version is referenced to 21. What level of support is desired for this library is up to the maintainers. I'll argue that at the very least it's gotta be newer than Java 8.