Skip to content

Build with JDK 21 #2888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

javanegmond
Copy link

As outlined in #2886, here's a change that will build and pass all tests except e2e tests. I've not had time to run e2e tests, but they compile.

Note that this very eagerly changes all locations where a java version is referenced to 21. What level of support is desired for this library is up to the maintainers. I'll argue that at the very least it's gotta be newer than Java 8.

Copy link

CLA Missing ID CLA Not Signed

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 14, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @javanegmond!

It looks like this is your first PR to kubernetes-client/java 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/java has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: javanegmond
Once this PR has been reviewed and has the lgtm label, please assign yue9944882 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 14, 2023
@brendandburns
Copy link
Contributor

I think it would be ok to take this as a separate branch, but we're not going to move to Java 21 on the mainline for now.

Even if we move forward, we're going to move forward to Java 11 or Java 17 not Java 21.

If you want to merge this into the mainline, the right option to move forward is to update the pom.xml to build two different versions of the library, not to replace the current version.

@yue9944882 wdyt?

@javanegmond
Copy link
Author

Even if we move forward, we're going to move forward to Java 11 or Java 17 not Java 21.

Sounds absolutely fair to me. Java 11 still has good support from multiple providers until some time in 2024 IIRC.

If you want to merge this into the mainline, the right option to move forward is to update the pom.xml to build two different versions of the library, not to replace the current version.

All up to you guys. I just wanted to do a quick run of what effort is necessary to be able to build with Java 21, which turns out is not a lot, but it's not a freebie either.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 26, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@brendandburns
Copy link
Contributor

Closing this as we have moved to a different plan to move forward to JDK11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants