Add default true to stdout and stderr on Exec. #227
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #225, though I would argue this is a breaking change for Kubernetes 1.9 and 1.10.
I'm going to try to repro and file a bug on upstream...
Sorry for the big diff. I also stripped
\r\n
from the file, I can revert for a cleaner diff if that is preferred.The key diff is:
in
Exec.java
@rjeberhard