Skip to content

Add default true to stdout and stderr on Exec. #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2018

Conversation

brendandburns
Copy link
Contributor

@brendandburns brendandburns commented Apr 2, 2018

Fixes #225, though I would argue this is a breaking change for Kubernetes 1.9 and 1.10.

I'm going to try to repro and file a bug on upstream...

Sorry for the big diff. I also stripped \r\n from the file, I can revert for a cleaner diff if that is preferred.

The key diff is:

+            + "&stdout=true"
+            + "&stderr=true"

in Exec.java

@rjeberhard

Copy link
Contributor

@rjeberhard rjeberhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing out what changed. I'm comfortable with this as one change. As a side note, I ran mvn fmt:format prior to my earlier push. How did we get \r\n line terminators in the file?

@brendandburns
Copy link
Contributor Author

@rjeberhard I think I might have originally written this file on Windows, I think that they've been there all along...

Merging.

@brendandburns brendandburns merged commit 299b4f6 into kubernetes-client:master Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants