-
Notifications
You must be signed in to change notification settings - Fork 304
remove unused util code #1042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove unused util code #1042
Conversation
tg123
commented
Sep 30, 2022
- remove duplicated generic code which impled
- remove unfinished cache/informer code (still missing informer reflector ...)
We used in our code the // constructor
_genericClient = new GenericClient(_kubernetesClient, GROUP, VERSION, PLURAL);
_genericKubernetesApi = new GenericKubernetesApi(GROUP, VERSION, PLURAL, _kubernetesClient);
// later
var watcher = _genericKubernetesApi.Watch(NAMESPACE, onEvent, onError, onClosed, cancellationToken); We are using this approach to be able to reconnect when the connection is lost (onClosed) and for the error logging. But how can we deal with reconnect and error logging in that case? |
thanks for reporting, will add |
@tg123 will watch be added to this PR? Or in a follow up? |
lets do it in followup |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, tg123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |