Skip to content

remove unused util code #1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 6, 2022
Merged

Conversation

tg123
Copy link
Member

@tg123 tg123 commented Sep 30, 2022

  • remove duplicated generic code which impled
  • remove unfinished cache/informer code (still missing informer reflector ...)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 30, 2022
@tg123
Copy link
Member Author

tg123 commented Sep 30, 2022

#846

@koepalex
Copy link

We used in our code the GenericKubernetesApi to watch kubernetes resources (namespaces scoped and global), this class was removed from nuget 9.0.x

// constructor
_genericClient = new GenericClient(_kubernetesClient, GROUP, VERSION, PLURAL);
_genericKubernetesApi = new GenericKubernetesApi(GROUP, VERSION, PLURAL, _kubernetesClient);
// later
var watcher = _genericKubernetesApi.Watch(NAMESPACE, onEvent, onError, onClosed, cancellationToken);

We are using this approach to be able to reconnect when the connection is lost (onClosed) and for the error logging.
With removing of the API, I think we need to change to, the way shown in Watch Example.

But how can we deal with reconnect and error logging in that case?

@tg123
Copy link
Member Author

tg123 commented Sep 30, 2022

thanks for reporting, will add watch as requested

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 29, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 30, 2022
@brendandburns
Copy link
Contributor

@tg123 will watch be added to this PR? Or in a follow up?

@tg123
Copy link
Member Author

tg123 commented Dec 5, 2022

@tg123 will watch be added to this PR? Or in a follow up?

lets do it in followup

@brendandburns
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, tg123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [brendandburns,tg123]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4d73757 into kubernetes-client:master Dec 6, 2022
@tg123 tg123 mentioned this pull request Dec 26, 2022
@tg123 tg123 deleted the cleanutil branch September 7, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants