Skip to content

Added register step in Jumpstart #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

keshav-chandak
Copy link
Owner

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

@saumitravikram saumitravikram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also how do we ensure we are running register just for open source model

@keshav-chandak keshav-chandak force-pushed the feature/jumpstart_register branch 10 times, most recently from bc5d530 to 5018e95 Compare October 19, 2023 07:06
@keshav-chandak keshav-chandak force-pushed the feature/jumpstart_register branch from 5018e95 to 2e4d73f Compare October 19, 2023 07:07
@keshav-chandak keshav-chandak force-pushed the master branch 4 times, most recently from 7064e0f to 14adab7 Compare January 29, 2024 05:37
@keshav-chandak keshav-chandak force-pushed the master branch 5 times, most recently from d5ba889 to 88ab7ee Compare February 26, 2024 05:58
@keshav-chandak keshav-chandak force-pushed the master branch 5 times, most recently from 5100933 to 580785b Compare October 1, 2024 13:18
@keshav-chandak keshav-chandak force-pushed the master branch 4 times, most recently from 1b34591 to c809ec0 Compare October 7, 2024 19:30
@keshav-chandak keshav-chandak force-pushed the master branch 3 times, most recently from 92ea5c4 to 2860730 Compare October 18, 2024 04:36
@keshav-chandak keshav-chandak force-pushed the master branch 2 times, most recently from da0fcd1 to 7c09242 Compare February 7, 2025 06:19
@keshav-chandak keshav-chandak force-pushed the master branch 10 times, most recently from 8ffc0d3 to 9f1bbf5 Compare February 27, 2025 06:37
@keshav-chandak keshav-chandak force-pushed the master branch 2 times, most recently from 71fe857 to 9ead9c8 Compare March 18, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants