Merge pull request swiftlang#4855 from MaskRay/compare_exchange

Azoy · web-flow · commit dbca8c7ddcfd · 2024-01-05T13:35:41.000-08:00
[runloop] Fix the failure memory order argument to atomic_compare_exchange_strong_explicit
diff --git a/CoreFoundation/RunLoop.subproj/CFRunLoop.c b/CoreFoundation/RunLoop.subproj/CFRunLoop.c
@@ -1306,7 +1306,7 @@ static Boolean __CFRunLoopSourceIsSignaled(CFRunLoopSourceRef rls) {
 }
 
 CF_INLINE void __CFRunLoopSourceSetSignaled(CFRunLoopSourceRef rls) {
-    atomic_compare_exchange_strong_explicit(&rls->_signaledTime, &(uint64_t){0}, mach_absolute_time(), memory_order_acq_rel, memory_order_acq_rel);
+    atomic_compare_exchange_strong_explicit(&rls->_signaledTime, &(uint64_t){0}, mach_absolute_time(), memory_order_acq_rel, memory_order_acquire);
 }
 
 CF_INLINE void __CFRunLoopSourceUnsetSignaled(CFRunLoopSourceRef rls) {

Original file line number	Diff line number	Diff line change
`@@ -1306,7 +1306,7 @@ static Boolean __CFRunLoopSourceIsSignaled(CFRunLoopSourceRef rls) {`
`1306`	`1306`	`}`
`1307`	`1307`
`1308`	`1308`	`CF_INLINE void __CFRunLoopSourceSetSignaled(CFRunLoopSourceRef rls) {`
`1309`		`- atomic_compare_exchange_strong_explicit(&rls->_signaledTime, &(uint64_t){0}, mach_absolute_time(), memory_order_acq_rel, memory_order_acq_rel);`
	`1309`	`+ atomic_compare_exchange_strong_explicit(&rls->_signaledTime, &(uint64_t){0}, mach_absolute_time(), memory_order_acq_rel, memory_order_acquire);`
`1310`	`1310`	`}`
`1311`	`1311`
`1312`	`1312`	`CF_INLINE void __CFRunLoopSourceUnsetSignaled(CFRunLoopSourceRef rls) {`