[CHORE] Add eslint-plugin-eslint-plugin (typescript-eslint#209)

Author: armano2

packages/eslint-plugin-typescript/.eslintrc

@@ -2,12 +2,14 @@
     "root": true,
     "plugins": [
         "node",
-        "prettier"
+        "prettier",
+        "eslint-plugin"
     ],
     "extends": [
         "eslint",
         "plugin:node/recommended",
-        "prettier"
+        "prettier",
+        "plugin:eslint-plugin/recommended"
     ],
     "rules": {
         "prettier/prettier": [
@@ -16,6 +18,9 @@
                 "tabWidth": 4
             }
         ],
-        "lines-around-comment": "off"
+        "lines-around-comment": "off",
+        "eslint-plugin/prefer-placeholders": "error",
+        "eslint-plugin/prefer-replace-text": "error",
+        "eslint-plugin/no-deprecated-report-api": "error"
     }
 }

packages/eslint-plugin-typescript/lib/rules/adjacent-overload-signatures.js

@@ -27,7 +27,7 @@ module.exports = {
         /**
          * Gets the name of the member being processed.
          * @param {ASTNode} member the member being processed.
-         * @returns {string} the name of the member or null if it's a member not relevant to the rule.
+         * @returns {string|null} the name of the member or null if it's a member not relevant to the rule.
          * @private
          */
         function getMemberName(member) {
@@ -92,7 +92,11 @@ module.exports = {
                     if (index > -1 && lastName !== name) {
                         context.report({
                             node: member,
-                            message: `All '${name}' signatures should be adjacent`,
+                            message:
+                                "All '{{name}}' signatures should be adjacent",
+                            data: {
+                                name,
+                            },
                         });
                     } else if (name && index === -1) {
                         seen.push(name);

packages/eslint-plugin-typescript/lib/rules/class-name-casing.js

@@ -67,9 +67,11 @@ module.exports = {
 
             context.report({
                 node: resolvedId,
-                message: `${friendlyName} '${
-                    resolvedId.name
-                }' must be PascalCased`,
+                message: "{{friendlyName}} '{{name}}' must be PascalCased",
+                data: {
+                    friendlyName,
+                    name: resolvedId.name,
+                },
             });
         }
 

packages/eslint-plugin-typescript/lib/rules/explicit-member-accessibility.js

@@ -41,9 +41,11 @@ module.exports = {
             ) {
                 context.report({
                     node: methodDefinition,
-                    message: `Missing accessibility modifier on method definition ${
-                        methodDefinition.key.name
-                    }.`,
+                    message:
+                        "Missing accessibility modifier on method definition {{name}}.",
+                    data: {
+                        name: methodDefinition.key.name,
+                    },
                 });
             }
         }
@@ -61,9 +63,11 @@ module.exports = {
             ) {
                 context.report({
                     node: classProperty,
-                    message: `Missing accessibility modifier on class property ${
-                        classProperty.key.name
-                    }.`,
+                    message:
+                        "Missing accessibility modifier on class property {{name}}.",
+                    data: {
+                        name: classProperty.key.name,
+                    },
                 });
             }
         }

packages/eslint-plugin-typescript/lib/rules/no-inferrable-types.js

@@ -122,7 +122,11 @@ module.exports = {
 
             context.report({
                 node,
-                message: `Type ${type} trivially inferred from a ${type} literal, remove type annotation`,
+                message:
+                    "Type {{type}} trivially inferred from a {{type}} literal, remove type annotation",
+                data: {
+                    type,
+                },
                 fix: fixer => fixer.remove(typeNode),
             });
         }

packages/eslint-plugin-typescript/lib/rules/type-annotation-spacing.js

@@ -117,15 +117,21 @@ module.exports = {
             if (after && nextDelta === 0) {
                 context.report({
                     node: punctuatorTokenEnd,
-                    message: `Expected a space after the '${type}'`,
+                    message: "Expected a space after the '{{type}}'",
+                    data: {
+                        type,
+                    },
                     fix(fixer) {
                         return fixer.insertTextAfter(punctuatorTokenEnd, " ");
                     },
                 });
             } else if (!after && nextDelta > 0) {
                 context.report({
                     node: punctuatorTokenEnd,
-                    message: `Unexpected space after the '${type}'`,
+                    message: "Unexpected space after the '{{type}}'",
+                    data: {
+                        type,
+                    },
                     fix(fixer) {
                         return fixer.removeRange([
                             punctuatorTokenEnd.range[1],
@@ -138,15 +144,21 @@ module.exports = {
             if (before && previousDelta === 0) {
                 context.report({
                     node: punctuatorTokenStart,
-                    message: `Expected a space before the '${type}'`,
+                    message: "Expected a space before the '{{type}}'",
+                    data: {
+                        type,
+                    },
                     fix(fixer) {
                         return fixer.insertTextAfter(previousToken, " ");
                     },
                 });
             } else if (!before && previousDelta > 0) {
                 context.report({
                     node: punctuatorTokenStart,
-                    message: `Unexpected space before the '${type}'`,
+                    message: "Unexpected space before the '{{type}}'",
+                    data: {
+                        type,
+                    },
                     fix(fixer) {
                         return fixer.removeRange([
                             previousToken.range[1],

packages/eslint-plugin-typescript/package.json

@@ -29,6 +29,7 @@
     "eslint-config-eslint": "^5.0.1",
     "eslint-config-prettier": "^3.3.0",
     "eslint-docs": "^0.1.1",
+    "eslint-plugin-eslint-plugin": "^2.0.0",
     "eslint-plugin-node": "^6.0.1",
     "eslint-plugin-prettier": "^3.0.0",
     "husky": "^1.2.0",

packages/eslint-plugin-typescript/tests/lib/rules/no-angle-bracket-type-assertion.js

@@ -33,7 +33,6 @@ const foo = {} as Foo<int>;
 const bar = new Generic<int>() as Foo;
         `,
         "const array : Array<string> = [];",
-        "const array : Array<string> = [];",
         `
 class A {}
 class B extends A {}

packages/eslint-plugin-typescript/tests/lib/rules/type-annotation-spacing.js

@@ -1041,11 +1041,6 @@ type Bar = Record<keyof Foo, string>
             parser: "typescript-eslint-parser",
         },
         "let resolver: (() => PromiseLike<T>) | PromiseLike<T>;",
-        `
-interface resolve {
-    resolver: (() => PromiseLike<T>) | PromiseLike<T>;
-}
-        `,
     ],
     invalid: [
         {
@@ -4234,11 +4229,6 @@ type Bar = Record<keyof Foo, string>
             ],
             parser: "typescript-eslint-parser",
         },
-        `
-interface resolve {
-    resolver?: (() => PromiseLike<T>) | PromiseLike<T>;
-}
-        `,
     ],
     invalid: [
         {

packages/eslint-plugin-typescript/yarn.lock

@@ -708,6 +708,11 @@ eslint-docs@^0.1.1:
     read-pkg-up "^2.0.0"
     regenerator-runtime "^0.11.0"
 
+eslint-plugin-eslint-plugin@^2.0.0:
+  version "2.0.0"
+  resolved "https://registry.yarnpkg.com/eslint-plugin-eslint-plugin/-/eslint-plugin-eslint-plugin-2.0.0.tgz#9825af354c8fcefda7c99c951243d70687dd9a1d"
+  integrity sha512-NLJ+Rw23xykBV12hQ/e4Kz8jbmtWSx++Q5dizfM8SjNQyUu/+AU4NUP4hih6iFMByKllTLR/hmVV8xwLpRBCPA==
+
 eslint-plugin-node@^6.0.1:
   version "6.0.1"
   resolved "https://registry.yarnpkg.com/eslint-plugin-node/-/eslint-plugin-node-6.0.1.tgz#bf19642298064379315d7a4b2a75937376fa05e4"