[FIX] [no-namespace] allow global augmentation (typescript-eslint#208)

armano2 · JamesHenry · commit ea801a6948a9 · 2019-01-18T07:42:16.000-05:00
diff --git a/packages/eslint-plugin-typescript/lib/rules/no-namespace.js b/packages/eslint-plugin-typescript/lib/rules/no-namespace.js
@@ -86,6 +86,7 @@ module.exports = {
         return {
             TSModuleDeclaration(node) {
                 if (
+                    node.global ||
                     isTypeScriptModuleDeclaration(node) ||
                     (allowDefinitionFiles && isDefinitionFile()) ||
                     (allowDeclarations && isDeclaration(node))
diff --git a/packages/eslint-plugin-typescript/tests/lib/rules/no-namespace.js b/packages/eslint-plugin-typescript/tests/lib/rules/no-namespace.js
@@ -21,6 +21,7 @@ const ruleTester = new RuleTester({
 
 ruleTester.run("no-namespace", rule, {
     valid: [
+        "declare global { }",
         "declare module 'foo' { }",
         {
             code: "declare module foo { }",

Original file line number	Diff line number	Diff line change
`@@ -21,6 +21,7 @@ const ruleTester = new RuleTester({`
`21`	`21`
`22`	`22`	`ruleTester.run("no-namespace", rule, {`
`23`	`23`	`valid: [`
	`24`	`+ "declare global { }",`
`24`	`25`	`"declare module 'foo' { }",`
`25`	`26`	`{`
`26`	`27`	`code: "declare module foo { }",`