Skip to content

Fix some styling issues #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Fix some styling issues #297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/variableinspector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,7 @@ namespace Private {
filterType.appendChild(varTypeOption);
filterType.appendChild(nameOption);
const searchContainer = document.createElement('div');
searchContainer.className = 'jp-InputGroup filter-search-container';
searchContainer.className = 'filter-search-container';
const input = document.createElement('jp-text-field') as TextField;
input.setAttribute('type', 'text');
input.setAttribute('placeholder', 'Filter out variable');
Expand Down Expand Up @@ -494,11 +494,10 @@ namespace Private {
const buttonText = document.createElement('div');
buttonText.className = 'filtered-variable-button-text';
buttonText.innerHTML = filterName;
const icon = closeIcon.element({
closeIcon.element({
container: filterButtonContent
});
filterButtonContent.appendChild(buttonText);
filterButtonContent.appendChild(icon);
filterButtonContent.insertAdjacentElement('afterbegin', buttonText);
filteredButton.appendChild(filterButtonContent);
filteredButton.className = FILTERED_BUTTON_CLASS;
return filteredButton;
Expand Down
3 changes: 2 additions & 1 deletion style/base.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
margin: auto;
width: 100%;
color: var(--jp-content-font-color1);
padding: 0 4px;
}

.jp-VarInspector-table td,
Expand Down Expand Up @@ -42,7 +43,7 @@
font-size: var(--jp-ui-font-size1);
color: var(--jp-content-font-color1);
text-align: left;
padding-left: 10px;
padding: 4px 10px;
}

.filter-container {
Expand Down