Skip to content

Make sure binary messages are proxied correctly (fixes #50) #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2018
Merged

Make sure binary messages are proxied correctly (fixes #50) #51

merged 1 commit into from
Oct 18, 2018

Conversation

adsche
Copy link
Contributor

@adsche adsche commented Oct 18, 2018

  • in on_message(), check if the received message is of type bytes and if so, send it on with binary flag
  • change 'message is bytes' to isinstance(message, bytes)

@adsche
Make sure binary messages are proxied correctly
9dbd162 
* in on_message(), check if the received message is of type bytes and if so, send it on with binary flag
* change 'message is bytes' to isinstance(message, bytes)
@adsche adsche changed the title Make sure binary messages are proxied correctly Make sure binary messages are proxied correctly (fixes #50) Oct 18, 2018
@betatim betatim merged commit ecc4343 into jupyterhub:master Oct 18, 2018
@betatim
Copy link
Member

betatim commented Oct 18, 2018 •
edited
Loading

Thanks for this! Closes #50

@adsche adsche mentioned this pull request Oct 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adsche @betatim