-
Notifications
You must be signed in to change notification settings - Fork 151
Update for JL 1.0.0-alpha.6 #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Woohoo thanks... this is a backwards incompatible change right? |
How do we deal with this incompatible change? Is there a way to detect at runtime (for a few releases) which code should run and issue a warning to those on older versions? I don't think there are many people who will straight away install a Jupyter Lab alpha release :-/ |
I can think of two ways offhand.
If you'd like I can go ahead and implement #1. |
Let's see what Yuvi thinks/get some input. Not putting it on PyPI is tricky because we'd be blocked from making any release once this PR has been landed and given JLab 1.0.0 has been "just around the corner" for a long time now ... maybe only land this PR once JLab 1.0.0 is out? How much less convenient would that be compared to having it in |
Oh man ignore me I got my pull requests mixed up and was answering the question about the Kubernetes APIs dropping V1DeleteOptions() as a requirement for deleting namespaced pods. In this case there's actually no Python involved and I think that npm install is smart enough to see that if the required dependencies are not there, to try other versions. dask-labextension is doing this with 0.4.0-pre (look at the releases tab): https://www.npmjs.com/package/dask-labextension We wouldn't want to call this "latest" until JL 1.0.0 release, but (based on the behavior of dask-labextension) we could tag it with a "pre" release version and put it on npm with the "next" tag). But run that by someone who actually understands npm, which isn't me. |
@athornton what I'd love to do is to add you as a maintainer here, on PyPI and on npm so you can help with this. How does that sound? |
Sure, although...if you're looking for actual npm (or TypeScript) expertise, it's not me... |
...just bumping this...did you give me the maintainer bits? I never saw any such notification but I have been kind of swamped with other stuff. |
@athornton Just invited you. |
Because I know even less about npm and JS: if we do this, can we keep releasing new releases that don't contain this? JupyterLab 1.0 has been "just around the corner" for a long time now so I wouldn't do anything that leads to us being blocked by lab 1.0 not yet being released. |
https://github.com/jupyter-widgets/ipywidgets/tree/master/packages/jupyterlab-manager does exactly this. it installs a different version depending on whether you are on 0.35.6 or 1.0.0a3. Jupyterlab 1.0 is 95 % complete https://github.com/jupyterlab/jupyterlab/milestone/2 |
I am about to supersede this. Basically: JL-1.0.0a6 is released, and my internal ticket tracking has changed from DM-18415 to DM-19974. |
#134 is the new hotness. |
No description provided.