Skip to content

Update for JL 1.0.0-alpha.6 #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

athornton
Copy link
Contributor

No description provided.

@yuvipanda
Copy link
Contributor

Woohoo thanks... this is a backwards incompatible change right?

@betatim
Copy link
Member

betatim commented Apr 27, 2019

How do we deal with this incompatible change? Is there a way to detect at runtime (for a few releases) which code should run and issue a warning to those on older versions? I don't think there are many people who will straight away install a Jupyter Lab alpha release :-/

@athornton
Copy link
Contributor Author

I can think of two ways offhand.

  1. Do the Pythonic thing, run the delete inside a try(), and if you get an exception, try the old way.
  2. (probably a good idea anyway) only release this to PyPi as a pre-release version until JL 1.0.0.

If you'd like I can go ahead and implement #1.

@betatim
Copy link
Member

betatim commented Apr 29, 2019

Let's see what Yuvi thinks/get some input.

Not putting it on PyPI is tricky because we'd be blocked from making any release once this PR has been landed and given JLab 1.0.0 has been "just around the corner" for a long time now ... maybe only land this PR once JLab 1.0.0 is out? How much less convenient would that be compared to having it in master but unreleased?

@athornton
Copy link
Contributor Author

Oh man ignore me I got my pull requests mixed up and was answering the question about the Kubernetes APIs dropping V1DeleteOptions() as a requirement for deleting namespaced pods.

In this case there's actually no Python involved and I think that npm install is smart enough to see that if the required dependencies are not there, to try other versions. dask-labextension is doing this with 0.4.0-pre (look at the releases tab):

https://www.npmjs.com/package/dask-labextension

We wouldn't want to call this "latest" until JL 1.0.0 release, but (based on the behavior of dask-labextension) we could tag it with a "pre" release version and put it on npm with the "next" tag). But run that by someone who actually understands npm, which isn't me.

@yuvipanda
Copy link
Contributor

@athornton what I'd love to do is to add you as a maintainer here, on PyPI and on npm so you can help with this. How does that sound?

@athornton
Copy link
Contributor Author

Sure, although...if you're looking for actual npm (or TypeScript) expertise, it's not me...

@athornton
Copy link
Contributor Author

...just bumping this...did you give me the maintainer bits? I never saw any such notification but I have been kind of swamped with other stuff.

@ryanlovett
Copy link
Collaborator

@athornton Just invited you.

@betatim
Copy link
Member

betatim commented May 24, 2019

We wouldn't want to call this "latest" until JL 1.0.0 release, but (based on the behavior of dask-labextension) we could tag it with a "pre" release version and put it on npm with the "next" tag). But run that by someone who actually understands npm, which isn't me.

Because I know even less about npm and JS: if we do this, can we keep releasing new releases that don't contain this? JupyterLab 1.0 has been "just around the corner" for a long time now so I wouldn't do anything that leads to us being blocked by lab 1.0 not yet being released.

@juliusvonkohout
Copy link

https://github.com/jupyter-widgets/ipywidgets/tree/master/packages/jupyterlab-manager does exactly this. it installs a different version depending on whether you are on 0.35.6 or 1.0.0a3. Jupyterlab 1.0 is 95 % complete https://github.com/jupyterlab/jupyterlab/milestone/2

@athornton
Copy link
Contributor Author

I am about to supersede this. Basically: JL-1.0.0a6 is released, and my internal ticket tracking has changed from DM-18415 to DM-19974.

@athornton
Copy link
Contributor Author

#134 is the new hotness.

@athornton athornton closed this Jun 5, 2019
@manics manics mentioned this pull request Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants