Skip to content

Commit 1d9e037

Browse files
committed
ci: test against jupyter-notebook and jupyter-lab in the same job
1 parent 6e340b1 commit 1d9e037

File tree

1 file changed

+11
-5
lines changed

1 file changed

+11
-5
lines changed

.github/workflows/test.yaml

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ jobs:
4040
python-version: ["3.8", "3.11"]
4141
jupyter_server-version: ["1", "2"]
4242
jupyterlab-version: ["2", "3"]
43-
jupyter-app: [notebook, lab]
4443

4544
steps:
4645
- uses: actions/checkout@v3
@@ -77,9 +76,16 @@ jobs:
7776
pip freeze
7877
pip check
7978
80-
- name: Run tests
79+
- name: Run tests against jupyter-notebook
8180
run: |
82-
JUPYTER_TOKEN=secret jupyter-${{ matrix.jupyter-app }} --config=./tests/resources/jupyter_server_config.py &
81+
JUPYTER_TOKEN=secret jupyter-notebook --config=./tests/resources/jupyter_server_config.py &
82+
sleep 5
83+
cd tests
84+
pytest -k "not acceptance"
85+
86+
- name: Run tests against jupyter-lab
87+
run: |
88+
JUPYTER_TOKEN=secret jupyter-lab --config=./tests/resources/jupyter_server_config.py &
8389
sleep 5
8490
cd tests
8591
pytest -k "not acceptance"
@@ -89,7 +95,7 @@ jobs:
8995
uses: actions/upload-artifact@v3
9096
with:
9197
name: |-
92-
unit-tests-${{ matrix.python-version }}-${{ matrix.jupyter-app }}-${{ matrix.jupyterlab-version }}-${{ github.run_number }}
98+
unit-tests-${{ matrix.python-version }}-${{ matrix.jupyterlab-version }}-${{ github.run_number }}
9399
path: |
94100
./build/pytest
95101
./build/coverage
@@ -133,6 +139,6 @@ jobs:
133139
uses: actions/upload-artifact@v3
134140
with:
135141
name: |-
136-
acceptance-tests-${{ matrix.python-version }}-${{ matrix.jupyter-app }}-${{ matrix.jupyterlab-version }}-${{ github.run_number }}
142+
acceptance-tests-${{ matrix.python-version }}-${{ matrix.jupyterlab-version }}-${{ github.run_number }}
137143
path: |
138144
./build/robot

0 commit comments

Comments
 (0)