Skip to content

Commit 6e340b1

Browse files
committed
ci: add back test for jupyter_server 1
This test was never explicit in the past, but we did it in the Python 3.7 setup as then jupyter_server 2 couldn't be installed.
1 parent cfffc60 commit 6e340b1

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

.github/workflows/test.yaml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,9 @@ jobs:
3737
strategy:
3838
fail-fast: false
3939
matrix:
40-
jupyterlab-version: ["2", "3"]
4140
python-version: ["3.8", "3.11"]
41+
jupyter_server-version: ["1", "2"]
42+
jupyterlab-version: ["2", "3"]
4243
jupyter-app: [notebook, lab]
4344

4445
steps:
@@ -69,7 +70,7 @@ jobs:
6970
#
7071
# Pytest options are set in tests/pytest.ini.
7172
run: |
72-
pip install -vv $(ls ./dist/jupyter_server_proxy-*.whl)\[acceptance\] 'jupyterlab~=${{ matrix.jupyterlab-version }}.0'
73+
pip install -vv $(ls ./dist/jupyter_server_proxy-*.whl)\[acceptance\] 'jupyterlab~=${{ matrix.jupyterlab-version }}.0' 'jupyter_server~=${{ matrix.jupyter_server-version }}.0'
7374
7475
- name: List Python packages
7576
run: |
@@ -117,7 +118,7 @@ jobs:
117118
# we have conditionally disabled this basic check is to avoid issues in
118119
# jupyterlab.browser_check with jupyterlab 2 and jupyter_server 2+.
119120
#
120-
if: matrix.jupyterlab-version != '2'
121+
if: ${{ !(matrix.jupyterlab-version == '2' && matrix.jupyter_server-version != '1') }}
121122
run: |
122123
jupyter labextension list
123124
jupyter labextension list 2>&1 | grep -iE '@jupyterhub/jupyter-server-proxy.*OK.*'

0 commit comments

Comments
 (0)