Skip to content

consolidated nodejs bump #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions bin/configurable-http-proxy
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,13 @@
//
"use strict";

var fs = require("fs"),
const fs = require("fs"),
pkg = require("../package.json"),
cli = require("commander"),
{ Command } = require("commander"),
tls = require("tls"),
winston = require("winston");

const cli = new Command();
cli
.version(pkg.version)
.option("--ip <ip-address>", "Public-facing IP of the proxy")
Expand Down
7 changes: 2 additions & 5 deletions lib/log.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
"use strict";
var strftime = require("strftime"),
winston = require("winston");
const winston = require("winston");

const simpleFormat = winston.format.printf((info) => {
// console.log(info);
Expand All @@ -13,9 +12,7 @@ function defaultLogger(options) {
winston.format.colorize(),
winston.format.label({ label: "ConfigProxy" }),
winston.format.splat(),
winston.format.timestamp({
format: () => strftime("%H:%M:%S.%L", new Date()),
}),
winston.format.timestamp(),
simpleFormat
);
options.transports = [new winston.transports.Console()];
Expand Down
3 changes: 3 additions & 0 deletions lib/testutil.js
Original file line number Diff line number Diff line change
Expand Up @@ -149,5 +149,8 @@ exports.teardownServers = function (callback) {
};
for (var i = servers.length - 1; i >= 0; i--) {
servers[i].close(onclose);
// closeAllConnections is implied in close in node >=19
// but this avoids waits between all tests with node 18
servers[i].closeAllConnections();
}
};
Loading