Skip to content

Restore node 10 as base supported engine #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2021
Merged

Restore node 10 as base supported engine #349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,13 @@ jobs:
strategy:
fail-fast: false # Do not cancel all jobs if one fails
matrix:
# IMPORTANT: Make sure to update package.json's enginges.node field to
# IMPORTANT: Make sure to update package.json's engines.node field to
# always require at least the oldest version, as well as our
# README.md file under the install section.
node_version:
- "12" # Remove 2022-04-30, its end-of-life.
# Removing node 10 is dropping support for ubuntu 20.04 LTS
- "10"
- "12"
- "14"
- "15" # Remove about when 17 is available?
- "16"
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ functionality to [JupyterHub] deployments.

## Install

Prerequisite: [Node.js](https://nodejs.org/en/download/) ≥ 12
Prerequisite: [Node.js](https://nodejs.org/en/download/) ≥ 10

If you're installing `configurable-http-proxy` in Linux, you can follow [the instruction of nodesource](https://github.com/nodesource/distributions#installation-instructions) to install arbitrary version of Node.js.

Expand Down
Loading