Simplify RELEASE.md with npm version #298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
reviewed
Mar 5, 2021
Using npm version is a little simpler and more natural for a javascript project than bump2version.
minrk
commented
Mar 5, 2021
| bump2version --tag release | ||
| # specify the new version here, | ||
| # which should already have been chosen when updating the changelog. | ||
| npm version 1.2.3 |
There was a problem hiding this comment.
This in particular, explicitly stating the new version, means we can't publish the wrong thing, whereas bump2version --tag release assumes the prior state was correct for the next released version.
There was a problem hiding this comment.
I've come to appreciate that ;) (EDIT: explicitly stating version, less complexity)
|
|
||
| ```bash | ||
| bump2version --no-tag patch | ||
| npm version --no-git-tag-version prerelease --preid=dev | ||
| git commit -am "back to dev" |
There was a problem hiding this comment.
It still boggles my mind that npm version doesn't have a 'commit but don't tag' option
minrk
commented
Mar 5, 2021
| @@ -0,0 +1 @@ | |||
| tag-version-prefix= | |||
There was a problem hiding this comment.
npm version's default is to use the v prefix on tags, but since we haven't been doing that (I don't happen like it, personally), this config lets us stay consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using npm version is a little simpler and more natural for a javascript project than bump2version.
closes #276