Emit proxyRequestWs events correctly, and some inline docs #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like we use the emit function to trigger potential event handlers registered, but from what I understand we should do this differently depending on either proxied web requests and proxied web socket requests. ref: https://github.com/http-party/node-http-proxy#listening-for-proxy-events
consideRatio
force-pushed
the
inline-docs-and-potential-fixes
branch
from
39514ac to
b635d86
Compare
|
Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like we use the emit function to trigger potential event
handlers registered, but from what I understand we should do this
differently depending on either proxied web requests and proxied web
socket requests.