Skip to content

Stop installing development dependencies in Docker image #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2020

Conversation

consideRatio
Copy link
Member

Running npm install on a local folder will by default also install the
devDependencies specified in package.json, and this is not suitable when
we are building a Dockerfile for use in production.

Running npm install on a local folder will by default also install the
devDependencies specified in package.json, and this is not suitable when
we are building a Dockerfile for use in production.
@minrk minrk changed the title Only install production dependencies in Dockerfile Merge pull request #227 from consideRatio/production-dockerfile Mar 12, 2020
@minrk minrk merged commit 99ed58c into jupyterhub:master Mar 12, 2020
@minrk
Copy link
Member

minrk commented Mar 12, 2020

Makes sense!

@consideRatio consideRatio changed the title Merge pull request #227 from consideRatio/production-dockerfile Stop installing development dependencies in Docker image Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants