Fix shadowMap interactive use + renderer props update + deprecations #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All renderers need to set their properties when acquiring.
This was preventing shadow maps properties from being updated correctly. What happened was: - onChange would trigger for WebGLShadowMap model - The base class syncToModel was called due to the typo - `save_changes` was called, which clears the `changed` attributes etc. - The `change` listener on `Renderer` would trigger, and try to look at the changed attributes. There might be a benefit to wrapping that save_changes call in a "callSoon" function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing some manual test before release, some fixes for various issues were discovered:
needsUpdatewas not being set correctly, due to a typo in the name of a method that was suppose to override its base implementation. See commit message for details about mechanism.setwhen not needed insyncToModel(correctly checks whether object keys are set).