Skip to content

fix: deprecated use of traitlets #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

maartenbreddels
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2021

Codecov Report

Merging #368 (a5d9511) into master (150ff1c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #368   +/-   ##
=======================================
  Coverage   70.86%   70.86%           
=======================================
  Files          23       23           
  Lines         834      834           
=======================================
  Hits          591      591           
  Misses        243      243           
Impacted Files Coverage Δ
pythreejs/traits.py 90.83% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 150ff1c...a5d9511. Read the comment docs.

@vidartf
Copy link
Member

vidartf commented Dec 7, 2021

The way I read this, it will also mean a drop of support for traitlets 4?

@maartenbreddels
Copy link
Member Author

Hmm, i didn't think about that actually.

@vidartf vidartf merged commit 16d7750 into jupyter-widgets:master Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants