Fixing the error that arise when using uneven width and height #360
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code for
SurfaceGeometry
works only whenwidth_segments==height_segments
. For example,will only run when
nx == ny
.Error arise when we have:
This is because in line 81
z = np.array(self.z).reshape((nx, ny))
the reshaped dimension is reversed.The proposed change fixed this error without interrupting any other part.