Remove travis-ci, split README/CONTRIBUTING #353
Conversation
Codecov Report
@@ Coverage Diff @@
## master #353 +/- ##
=======================================
Coverage 70.86% 70.86%
=======================================
Files 23 23
Lines 834 834
=======================================
Hits 591 591
Misses 243 243 Continue to review full report at Codecov.
|
.binder/postBuild
Outdated
| jupyter labextension develop . --overwrite | ||
| popd | ||
| python setup.py sdist | ||
| python -m pip install -v dist/pythreejs*.tar.gz --no-deps --ignore-installed |
There was a problem hiding this comment.
Does this not cause a new build when installing from the sdist? It might be more optimal to install via wheel?
There was a problem hiding this comment.
it probably does... i'm more interested in robust than optimal, and frankly care more about what makes it to the (intermediate) .tar.gz than the .whl... but faster is of course better. will try a few more things...
There was a problem hiding this comment.
--no-build-isolation saves a some stuff (e.g recompiling pyrsistent and pandocfilters).
Unfortunately, the way --skip-npm is passed down, if you have node, it's going to rebuild... perhaps optionally checking a PYTHREEJS_SKIP_NPM would be more robust. Or if the stale check worked...
There was a problem hiding this comment.
To be clear, my suggestion was to use python setup.py bdist_wheel and then pip install using the wheel. That should do what you want while still avoiding rebuilds, right ?
There was a problem hiding this comment.
(if you are saying this is meant to be a test of the sdist install, that is probably different).
|
I think this is about as good as I can get the simple docs and binder working for now. Probably some more issues are needed, but this would probably generate some pretty good packages at this point, modulo updating the LICENSE information. |
js/README.md
Outdated
| ```bash | ||
| yarn add jupyter-threejs | ||
| jlpm add jupyter-threejs | ||
| ``` |
There was a problem hiding this comment.
The npm/yarn/jlpm add command is not a dev install prerequisite. I believe the previous bit here was also not very helpful, so it is probably best to delete all of it and just link to the contributing document.
There was a problem hiding this comment.
Tuned that up, and added the LICENSE so that it gets included in the npm distribution (and all the other places).
There was a problem hiding this comment.
also, of note: there's no .npmignore or files in package.json, so... a lot of stuff gets into the tarball (scripts, src, the linter config, the lab dist tarball, etc). that could probably be tuned up...
There was a problem hiding this comment.
Good point, I'll have a look at cleaning up the tarball.
|
Merging as is, will iterate on the tarball and then do the release. |
|
Gave the binder a shake, looking good. Now in badgetopia, we're just down to docs... will have a look... |
So long, travis, thanks for all the builds!
This PR:
environment.ymlto.binderfoldermaster, the docs build will presently failipywidgetsNot on this PR:
rst