Skip to content

Improved extension install instructions for lab vs. notebook #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2019
Merged

Conversation

taiya
Copy link
Contributor

@taiya taiya commented May 9, 2019

Resolves Issue #267

@stonebig
Copy link

stonebig commented Jun 30, 2019

I may be wrong, but isn't pythreejs included per default in Jupyterlab-1.0.0.rc1 ?

@vidartf
Copy link
Member

vidartf commented Jul 1, 2019

I think you are mistaken. Pythreejs is not distributed with jupyterlab, and I don't think it ever has been.

@vidartf vidartf merged commit 35d2c13 into jupyter-widgets:master Jul 3, 2019
@taiya taiya deleted the patch-1 branch July 3, 2019 12:38
@stonebig
Copy link

stonebig commented Jul 3, 2019

will retry with latest jupyterlab

@vidartf
Copy link
Member

vidartf commented Jul 4, 2019

Pythreejs hasn't been ported to lab 1.0 yet, hoping to get it done by the end of the week.

@stonebig
Copy link

stonebig commented Jul 4, 2019

so, I'm apparently stable in Python-3.7 now
image

and Animation.ipynb works great. now checking back in Python-3.8

@vidartf
Copy link
Member

vidartf commented Jul 4, 2019

I just released 2.1.1 earlier today 😄

@taiya
Copy link
Contributor Author

taiya commented Jul 5, 2019

@vidartf did you make any tests regarding whether it works under jupyter lab?

@vidartf vidartf mentioned this pull request Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants