break reference loop using weakref to prevent memory-leaking

[chaoslawful]

This patch should fix memory-leaking issue #57

[julien-duponchelle]

It sound a good idea

But in test we got a lot of:

ReferenceError: weakly-referenced object no longer exists

2014-10-23 11:31 GMT+02:00 Wang, Xiaozhe [email protected]:

This patch should fix memory-leaking issue
#57

#57

You can merge this Pull Request by running

git pull https://github.com/chaoslawful/python-mysql-replication master

Or view, comment on, or merge it at:

#98
Commit Summary

• break reference loop using weakref to prevent memory-leaking

File Changes

• M pymysqlreplication/binlogstream.py
  https://github.com/noplay/python-mysql-replication/pull/98/files#diff-0
  (3)

Patch Links:

• https://github.com/noplay/python-mysql-replication/pull/98.patch
• https://github.com/noplay/python-mysql-replication/pull/98.diff

Reply to this email directly or view it on GitHub
#98.

[chaoslawful]

Hmmm...I got this problem in one of our testing box too. But what confused me is that the problem didn't appear on other testing boxes with exactly the same environment. My best guess is that it related with some internal issues in python's weakref module.

Anyway, we can always explicitly break reference cycle in BinLogStreamReader's close method. I just committed the changes.

[julien-duponchelle]

Great thanks for the patch