Skip to content

Fix unit tests #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 15, 2014
Merged

Fix unit tests #76

merged 3 commits into from
Jul 15, 2014

Conversation

julien-duponchelle
Copy link
Owner

It's fixe the test suite after two errors:

  • invalid boolean tests
  • an crash when we have no PRIMARY KEY

@julien-duponchelle
Copy link
Owner Author

@lxyu 79acd70 could interest you

@lxyu
Copy link
Contributor

lxyu commented Jul 14, 2014

The COLUMN_KEY is selected in sql by
https://github.com/noplay/python-mysql-replication/blob/ff22b99dc1846b0be5d8b0d9d736ebde0ba992c5/pymysqlreplication/binlogstream.py#L192

so why it can be absent from column_schema?

@julien-duponchelle
Copy link
Owner Author

You are right the test was invalid, i have fixed it. It's ok for you?

@bjoernhaeuser
Copy link
Collaborator

👍

julien-duponchelle added a commit that referenced this pull request Jul 15, 2014
@julien-duponchelle
Merge pull request #76 from noplay/fix_unit_tests
6ef4d86 
Fix unit tests
@julien-duponchelle julien-duponchelle merged commit 6ef4d86 into master Jul 15, 2014
@julien-duponchelle julien-duponchelle deleted the fix_unit_tests branch July 15, 2014 09:21
@julien-duponchelle julien-duponchelle restored the fix_unit_tests branch May 10, 2015 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julien-duponchelle @lxyu @bjoernhaeuser