-
Notifications
You must be signed in to change notification settings - Fork 683
Add properties in gtid event #586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Bue-von-hon
wants to merge
7
commits into
julien-duponchelle:main
Choose a base branch
from
Bue-von-hon:feature/add-properties-in-gtid-event
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
14fb3ef
Add properties in gtid event
87b13fe
Fix lint
0ec673d
Resolves in code review
e6b2a54
Update pymysqlreplication/tests/test_basic.py
Bue-von-hon a35b344
Update pymysqlreplication/tests/test_basic.py
Bue-von-hon 76c35d1
Resolves in code review
Bue-von-hon 3b182d7
Fix mysql versionfor test
Bue-von-hon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,7 +14,6 @@ | |
from pymysql.protocol import MysqlPacket | ||
import pytest | ||
|
||
|
||
__all__ = [ | ||
"TestBasicBinLogStreamReader", | ||
"TestMultipleRowBinLogStreamReader", | ||
|
@@ -1473,6 +1472,41 @@ def test_rows_query_log_event(self): | |
self.assertIsInstance(event, RowsQueryLogEvent) | ||
|
||
|
||
class TestGtidEvent(base.PyMySQLReplicationTestCase): | ||
def setUp(self): | ||
super(TestGtidEvent, self).setUp() | ||
self.execute("SET SESSION binlog_rows_query_log_events=1") | ||
|
||
def tearDown(self): | ||
self.execute("SET SESSION binlog_rows_query_log_events=0") | ||
super(TestGtidEvent, self).tearDown() | ||
|
||
def test_gtid_event(self): | ||
self.stream.close() | ||
self.stream = BinLogStreamReader( | ||
self.database, | ||
server_id=1024, | ||
only_events=[GtidEvent, FormatDescriptionEvent], | ||
) | ||
if not self.isMySQL57AndMore(): | ||
self.skipTest("Mysql version is under 5.7") | ||
self.execute( | ||
"CREATE TABLE IF NOT EXISTS test (id INT AUTO_INCREMENT PRIMARY KEY, name VARCHAR(255))" | ||
) | ||
gtid_event = self.stream.fetchone() | ||
|
||
self.assertIsInstance(gtid_event, GtidEvent) | ||
self.assertIsInstance(gtid_event.event_type, int) | ||
self.assertIsInstance(gtid_event.sid, bytes) | ||
self.assertIsInstance(gtid_event.gno, int) | ||
self.assertIsInstance(gtid_event.lt_type, int) | ||
self.assertIsInstance(gtid_event.last_committed, int) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Upper mysql 5.7 version has this variable so pytest failed.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Resolves it! |
||
self.assertIsInstance(gtid_event.sequence_number, int) | ||
self.assertEqual(gtid_event.sequence_number, 1) | ||
self.assertIsInstance(gtid_event.immediate_commit_timestamp, bytes) | ||
self.assertIsInstance(gtid_event.original_commit_timestamp, bytes) | ||
|
||
|
||
class TestLatin1(base.PyMySQLReplicationTestCase): | ||
def setUp(self): | ||
super().setUp(charset="latin1") | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should grep FormatEvent too
Now gtid_event assign FormatDescriptionEvent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After i grep FormatDescriptionEvent, test was passed in my local env. 👍