fake rotate event check #579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-k1
force-pushed
the
fake-rotate-event-check
branch
3 times, most recently
from
7cee733 to
143ebe6
Compare
sean-k1
force-pushed
the
fake-rotate-event-check
branch
from
143ebe6 to
0432899
Compare
not initailizing table map when fake rotate Event add black lint
sean-k1
force-pushed
the
fake-rotate-event-check
branch
from
0432899 to
1d5dfcf
Compare
|
Hi there! Can you please repeat the changes for the version v0.45.+? I use mysql version 5.7 and caught the same problem. I found that your PR already resolved this problem, but for version 1.0.+. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
resolve #578
We initialize the table_map when we create the binlogstreamreader object.
After that, if the binlog is maxsize full, a rotateEvent is fired.
At that point, we empty the table_map because the timestamp is not zero.
Then, when we connect to the next binlogfile, we get a rotateEvent with a timestamp of 0. We don't need to empty the table_map again.
However, when we disconnect from mysql and reconnect, we get a fake rotateEvent with a 0 timestamp.
In this case, we inform the client of error logging and do not initialize the table map.
Type of Change
Checklist
Tests
Additional Information