-
Notifications
You must be signed in to change notification settings - Fork 685
Updated Examples and Changelog in Readme.md #557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -288,7 +315,7 @@ https://python-mysql-replication.readthedocs.org/en/latest/developement.html | |||
|
|||
Changelog | |||
========== | |||
https://github.com/noplay/python-mysql-replication/blob/master/CHANGELOG | |||
https://github.com/noplay/python-mysql-replication/blob/main/CHANGELOG |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool!
README.md
Outdated
MYSQL_SETTINGS = {"host": "127.0.0.1", "port": 3306, "user": "root", "passwd": ""} | ||
|
||
stream = BinLogStreamReader(connection_settings = mysql_settings, server_id=100) | ||
|
||
for binlogevent in stream: | ||
binlogevent.dump() | ||
def main(): | ||
stream = BinLogStreamReader( | ||
connection_settings=MYSQL_SETTINGS, server_id=3, blocking=True | ||
) | ||
|
||
stream.close() | ||
for binlogevent in stream: | ||
binlogevent.dump() | ||
|
||
stream.close() | ||
|
||
|
||
if __name__ == "__main__": | ||
main() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't mean for you to change this area.
I was asking to change the link on line 115.
I'm sorry I didn't convey my intentions clearly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry It was my mistake. I resolved the issue now. Changed the "Example Directory"
from https://github.com/noplay/python-mysql-replication/tree/master/examples
to https://github.com/noplay/python-mysql-replication/tree/main/examples
additionally I roll backed the changes done to Example and Output code in example block.
Changed Example Directory link, also reversed the changes doen to Example code and output.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Thanks your hard Work!
Updated Changelog
from https://github.com/noplay/python-mysql-replication/blob/master/CHANGELOG
to https://github.com/noplay/python-mysql-replication/blob/main/CHANGELOG
Updated Examples block
from
to
Also updated the output according to the new code