fix : f-string formatting binlogstream.py L511 #556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it would be better to make commit message as english since this project runs globally |
HongGeonUi
force-pushed
the
enhancement/f-string-HongGeonUi2
branch
from
dde88c4 to
e9d58a4
Compare
Sorry, I recognized that, but I had mistakes. |
sean-k1
reviewed
Oct 17, 2023
pymysqlreplication/binlogstream.py
Outdated
| @@ -507,7 +507,7 @@ def __set_mariadb_settings(self): | |||
| # https://mariadb.com/kb/en/5-slave-registration/ | |||
| cur = self._stream_connection.cursor() | |||
| if self.auto_position is not None: | |||
| cur.execute("SET @slave_connect_state='%s'" % self.auto_position) | |||
| cur.execute(f'SET @slave_connect_state= "{self.auto_position}"') | |||
There was a problem hiding this comment.
Can you change erase space
Suggested change
| cur.execute(f'SET @slave_connect_state= "{self.auto_position}"') | |
| cur.execute(f'SET @slave_connect_state="{self.auto_position}"') |
There was a problem hiding this comment.
Sure, I erase the space.
sean-k1
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #536
I apply f-string formatting