add: send mysql_to_rabbitmq.py #547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes 545
myminju
changed the title
sean-k1
reviewed
Oct 16, 2023
Comment on lines
+42
to
+54
| for binlogevent in stream: | ||
| for row in binlogevent.rows: | ||
| if isinstance(binlogevent, DeleteRowsEvent): | ||
| routing_key = "order" | ||
| message_body = row["values"].items() | ||
|
|
||
| elif isinstance(binlogevent, UpdateRowsEvent): | ||
| routing_key = "order" | ||
| message_body = row["after_values"].items() | ||
|
|
||
| elif isinstance(binlogevent, WriteRowsEvent): | ||
| routing_key = "order" | ||
| message_body = row["values"].items() |
There was a problem hiding this comment.
better use routing_key just once.
and I think routing_key == order is little bit Doesn't fit.
|
I'm gonna test this on local RabbitMQ |
|
I have tested your code thoroughly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #545