Skip to content

fix : f-string formatting redis_cache.py #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Choirong
Copy link
Contributor

Summary

This PR updates lines 30 to 33 in redis_cache.py, transitioning from the older % format style to the more modern and readable f-string format.

Changes

  • Updated string formatting on lines 30-33 to utilize Python's f-string syntax.

Rationale

F-strings offer a more intuitive and clean way to format strings in Python, enhancing both readability and performance. This change ensures that our code in redis_cache.py remains consistent with modern Python practices.

Would appreciate a review of this change to ensure it aligns with our coding standards and practices.

Thank you!

Copy link
Collaborator

@sean-k1 sean-k1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks your hardwork!

@sean-k1 sean-k1 merged commit 7262698 into julien-duponchelle:main Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants