Remove python2 and mysql5.7 code #515
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-k1
reviewed
Oct 12, 2023
understood I will apply this in following commit |
|
We cannot overlook the MySQL 5.7 user base. I know MySQL declared EOL for 5.7 but there are plenty of users that can benefit from the code. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while looking around repository I came across python2, mysql 5.7 tests, codes
and Github Actions which was deprecated in python-mysql-replication version 1.0
However, I think there should be some improvement over config.json and docker-compse.yml
Since config.json port setting depends on docker-compose file.