-
Notifications
You must be signed in to change notification settings - Fork 683
Remove python2 and mysql5.7 code #515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove python2 and mysql5.7 code #515
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you delete all mysql 5.7 version Test
it would be better set global variable binlog_row_metadata = "FULL" in setUp method.
understood I will apply this in following commit |
We cannot overlook the MySQL 5.7 user base. I know MySQL declared EOL for 5.7 but there are plenty of users that can benefit from the code. |
while looking around repository I came across python2, mysql 5.7 tests, codes
and Github Actions which was deprecated in python-mysql-replication version 1.0
However, I think there should be some improvement over config.json and docker-compse.yml
Since config.json port setting depends on docker-compose file.