We need a logic to convert events into JSON format. #491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-k1
reviewed
Oct 3, 2023
Comment on lines
+773
to
+774
| if self.optional_metadata: | ||
| result_dict.update(self.optional_metadata.to_json()) |
There was a problem hiding this comment.
self.optional_metadata always got object so it is Not None
optional_metadata = OptionalMetaData()
try this variable self.__optional_meta_data when check
and can we get some testcases?
Comment on lines
+147
to
+157
| def _to_json(self): | ||
| gtid_event_dict = { | ||
| "event_name": type(self).__name__, | ||
| "commit": self.commit_flag, | ||
| "gtid_next": self.gtid, | ||
| } | ||
| if hasattr(self, "last_committed"): | ||
| gtid_event_dict["last_committed"] = self.last_committed | ||
| gtid_event_dict["sequence_number"] = self.sequence_number | ||
| return gtid_event_dict | ||
|
|
There was a problem hiding this comment.
some test cases is more good for us
Comment on lines
+930
to
+944
| def _to_json(self): | ||
| user_var_event_dict = { | ||
| "event_name": type(self).__name__, | ||
| "user_variable_name": self.name, | ||
| } | ||
| if not self.is_null: | ||
| user_var_event_dict["type"] = self.type_to_codes_and_method.get( | ||
| self.type, ["UNKNOWN_TYPE"] | ||
| )[0] | ||
| user_var_event_dict["charset"] = self.charset | ||
| user_var_event_dict["value"] = self.value | ||
| user_var_event_dict["flags"] = self.flags | ||
|
|
||
| return user_var_event_dict | ||
|
|
There was a problem hiding this comment.
some test cases is more good for us
sean-k1
reviewed
Oct 3, 2023
| def _to_json(self): | ||
| return { | ||
| "event_name": type(self).__name__, | ||
| "schema": self.schema.decode("utf-8"), |
There was a problem hiding this comment.
563 Line I think it's better to send it in the same form as the dump, but what do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In the majority of projects utilizing the
pymysqlreplicationlibrary, it has been observed that binlog events are being converted into JSON format for usage.[Examples]
Streaming Changes in a Database with Amazon Kinesis
Near Zero Downtime Migration from MySQL to DynamoDB
Consequently, we have developed logic within our library to provide binlog events in JSON format.
How to execute
Results
{ "evnet_type": 30, "date": "2023-09-29T04:15:11", "log_pos": 994, "event_size": 103, "read_bytes": 12, "table": ["test", "r1"], "affected_columns": 3, "changed_rows": 7, "flag": true, "event_name": "WriteRowsEvent", "rows": [{ "values": { "i1": 1, "c1": "#1", "d1": "2023-09-29T04:15:11" } }, { "values": { "i1": 2, "c1": "#2", "d1": "2023-09-29T04:15:11" } }, { "values": { "i1": 3, "c1": "#3", "d1": "2023-09-29T04:15:11" } }, { "values": { "i1": 4, "c1": "#4", "d1": "2023-09-29T04:15:11" } }, { "values": { "i1": 5, "c1": "#5", "d1": "2023-09-29T04:15:11" } }, { "values": { "i1": 6, "c1": "#6", "d1": "2023-09-29T04:15:11" } }, { "values": { "i1": 7, "c1": "#7", "d1": "2023-09-29T04:15:11" } }] }Benefit
Through this logic, users can reduce the steps needed for additional processing.
The connection between heterogeneous software through JSON is expected to become more smooth and seamless.