Skip to content

Incorrect Parsing of Extra Data(NDB info) in Rows Event #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

chungeun-choi
Copy link
Contributor

The following is the code for parsing rows events within the Rows Event. It was observed that the nbd_info_length and nbd_info_format should each be read as 1-byte values, so they need to be modified to self.packet.read(2).

  • The table below is derived from comments in the MySQL source code, describing the format of extra data (NDB info):

     	+----------+--------------------------------------+
            |type_code |        extra_row_ndb_info            |
            +--- ------+--------------------------------------+
            | NDB      |Len of ndb_info |Format |ndb_data     |
            | 1 byte   |1 byte          |1 byte |len - 2 byte |
            +----------+----------------+-------+-------------+

@julien-duponchelle julien-duponchelle merged commit 2e439b6 into julien-duponchelle:main Sep 12, 2023
@julien-duponchelle
Copy link
Owner

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants