Enhance Code Quality with Ruff, Black, and Pre-commit #456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… line 1012 by rename into TestMariadbBinlogStreamReader2
|
Awesome ! |
|
Can you help me to solve the conflicts ? |
|
Sure! I'll solve conflicts ASAP. |
|
I fixed all conflicts! |
|
Sorry I introduced more conflict .. I have try quickly to solve #475 but test failed . I will come back to it later. |
|
@julien-duponchelle I fix all conflicts. Ready-to-be-merged! |
|
Amazing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I've made some changes that I believe will enhance the code quality of the
python-mysql-replicationproject. Here are the improvements made:GitHub Actions with ruff and black: I've set up a GitHub Actions workflow that runs both ruff and black. This will help ensure that all code contributions adhere to the desired coding standards. If a commit does not comply with these standards, the CI checks will fail, prompting the contributor to make necessary changes.
Pre-commit Setup: To make it easier for contributors, I've added a pre-commit hook that will automatically format the code using ruff and black every time a commit is made. This not only saves time but also ensures that each commit is formatted correctly before it's even pushed.
CONTRIBUTING.md: I've added a
CONTRIBUTING.mdfile that provides guidelines on how to set up and use the pre-commit hooks. This will help new contributors get started and ensure consistency in contributions.Code Formatting: Lastly, I've gone through the existing code and reformatted it using Ruff and Black to ensure it complies with the new standards.
I believe these changes will greatly improve the overall code quality and maintainability of the project. I'm open to feedback and would love to collaborate further on refining this!