Fix Timestamp conversion to return UTC instead of local timezone #443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the issue described in #442. During the testing of python-mysql replication, specifically with the
test_timestamp, it was found that timestamps were being converted to the local timezone instead of being returned as UTC.Changes
Timestamp Conversion: Modified the code where the
fromtimestampmethod is called, to ensure that the timestamp is returned as UTC rather than being converted to the local timezone by usingutcfromtimezone.Impact
This change ensures that the timestamp handling aligns with how MySQL itself manages timestamps, providing consistency and predictable behavior. The modification adheres to the project's philosophy of parsing the replication protocol and passing it to users.
Testing
The changes have been tested on a local Mac system with a time difference of UTC+9 (Korean Standard Timezone), using containers with docker-compose. All relevant tests have been updated and are passing.
Fixed: #442