'slave_uuid' was deprecated from MySQL 8.0.22 #429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
I like the addtional consideration it seem a good idea |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Issue: #428 (SHOW SLAVE HOSTS was deprecated from MySQL 8.0.22)
Problem
Since the
SHOW SLAVE HOSTSstatement was deprecated from MySQL 8.0.22[1], the MySQL variableslave_uuidis also be deprecated.Solution
To ensure version compatibility, both the
replica_uuidandslave_uuidvariables will be set to the MySQL Server.This approach aligns with what was done in go-mysql[2].
Additional Consideration
It would be prudent to change the name of the
slave_uuidattribute toserver_uuid, as it encapsulates the meanings of bothslave_uuidandreplica_uuid.[1] SHOW SLAVE HOSTS | SHOW REPLICAS Statement (MySQL Docs)
[2] Set slave_uuid and replica_uuid (go-mysql-org/go-mysql)