Return if the stream is nonblocking #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the stream is nonblocking we actually get this invalid packet and should just stop.
|
Perhaps we can test if it's an EOF packet |
|
Just updated, what do you think? |
|
Yeah i think it's ok. I think we can add a test in order to avoid breaking it |
|
I think the other tests problems you had are the same I had. This should fix both. |
julien-duponchelle
added a commit
that referenced
this pull request
Jun 27, 2013
Return if the stream is nonblocking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the stream is nonblocking we actually get this invalid packet and
should just stop.
@noplay you introduced the new behaviour. I think we need to stop the stream if we got such an packet. What do you think? This could have also caused the problem you had with your tests?