Skip to content

refactor : refactor loop inside _read_column_data method #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 26, 2023
Merged

refactor : refactor loop inside _read_column_data method #418

merged 3 commits into from
Aug 26, 2023

Conversation

mirageoasis
Copy link
Contributor

  • refactored structure inside loop to improve readability

  • separated read values[name] and nullBitmapIndex increase because I think reading and chaning value should not be done once

image

  • refactored nullBitmapIndex to null_bitmap_index to follow pep8

@mirageoasis mirageoasis marked this pull request as ready for review August 25, 2023 03:14
@julien-duponchelle
Copy link
Owner

I'm sorry but the code will need to be rebased against the last version

@mirageoasis
Copy link
Contributor Author

Done with conflicts!

@julien-duponchelle julien-duponchelle merged commit a19a5a5 into julien-duponchelle:main Aug 26, 2023
@mirageoasis mirageoasis deleted the refactor_read_column_data branch August 27, 2023 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mirageoasis @julien-duponchelle