A bunch of small changes #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
May 2, 2013 10:18
according to this post http://dev.mysql.com/doc/internals/en/row-based-replication.html#rows-event events are marked as version 0,1,2 (current) - the code had _V1 and no version at all - I think it would b easier and morefuture compatible to use V2 since it seems V3 is unavoidable.
Conflicts: pymysqlreplication/row_event.py pymysqlreplication/tests/test_basic.py
nullevent is an event that can happen in the steam but we want to skip it. added two sample events like that: INTVAR_EVENT and GTID_LOG_EVENT - those are events that happen when we do GTID enabled replication, but are of no use (at least not for me at this time) in this packages aspect. It might be when we support moving to a different master seamlessly.
Conflicts: pymysqlreplication/constants/BINLOG.py pymysqlreplication/event.py pymysqlreplication/packet.py
| @@ -59,6 +59,10 @@ def test_connection_stream_lost_event(self): | |||
| self.stream.fetchone() | |||
|
|
|||
| event = self.stream.fetchone() | |||
|
|
|||
| while (type(event) == NotImplementedEvent): | |||
There was a problem hiding this comment.
|
Merged, and in commit 95e91c7 i made small refactor of the readme about tests. |
|
thanks :) I should really get me some markdown editor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
those are all small changes that I didn't bother branch each, hope it's ok: