MySQL Broken Dates :( #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok from documentation: |
julien-duponchelle
added a commit
that referenced
this pull request
May 15, 2013
MySQL Broken Dates :(
|
I push a test for this: |
I think we should support all cases. For some use case we can't lost a value and it's better to crash. But if we see a lot of new crash perhaps a skip_error option can be add in the futur. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
We just hat another problem with broken Dates in MySQL:
21.01.0000The routines I added did not cover this issue, therefore I added some more code.
I also thought that maybe parsing of some values should not fail the whole parsing, but thats another issue.
What do you think?
Thanks
Björn