Implement Heartbeat #191
Merged
Implement Heartbeat #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baloo
force-pushed
the
features/heartbeat-events
branch
from
8778000 to
b9587d1
Compare
|
Nice |
baloo
force-pushed
the
features/heartbeat-events
branch
from
b9587d1 to
82cfbec
Compare
|
@noplay I'm concerned about the new events in the stream. This may break the client apps. Maybe I should remove it from the default set. |
added 2 commits
January 31, 2017 23:37
I ended up debugging a slow startup with pymysqlreplication, the stream "stucked" for a few seconds before seeing first events coming in. For that purpose I ended up implementing HeartbeatLogEvent and documenting observed mysql behavior. I also implemented the heartbeat feature, which is required for the mysqld to filter events in gtid mode. Signed-off-by: Arthur Gautier <[email protected]>
Signed-off-by: Arthur Gautier <[email protected]>
baloo
force-pushed
the
features/heartbeat-events
branch
from
7a3b79a to
f12a190
Compare
|
In which scenario do you think it can break?
Le mar. 31 janv. 2017 à 22:55, Arthur Gautier <[email protected]> a
écrit :
… @noplay <https://github.com/noplay> I'm concerned about the new events in
the stream. This may break the client apps. Maybe I should remove it from
the default set.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#191 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAVFXTdEV1nwizlbq-y8ECLUsvciUax0ks5rX63CgaJpZM4LwWKX>
.
|
|
New unexpected event in the stream. That's the only one I see. |
|
If user don't want to receive unexpected events they should use the
only_events array. Perhaps we need to make that more clear.
Le mer. 1 févr. 2017 à 23:21, Arthur Gautier <[email protected]> a
écrit :
… New unexpected event in the stream. That's the only one I see.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#191 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAVFXd1tzwRAee6O7ykUKMSiTVe_YjlLks5rYQV4gaJpZM4LwWKX>
.
|
|
Agreed |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ended up debugging a slow startup with pymysqlreplication,
the stream "stucked" for a few seconds before seeing first events coming in.
For that purpose I ended up implementing HeartbeatLogEvent and
documenting observed mysql behavior.
I also implemented the heartbeat feature, which is required for the mysqld
to filter events in gtid mode.