Introduce data objects for Table / Column #19
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Table and Column objects are now there for just holding every data in self.data. This makes its easier to serialize these objects.
|
I just read the code and it sound good, i will test it tonight. |
|
Tested with Python 2.7 and 3 it's work |
|
Merged 58029d5 |
|
I'm sorry but i have cherry pick your commit instead of merging the pull request. You can see we have a commit already merged in the pull request: I think the best way to avoid this is to make pull request from a feature branch. Thanks a lot for the precious contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I am currently trying to serialize the
table_mapto a file. The thing is the table_map consists ofTableMapEvents, which makes it rather hard to get a good serializable Object.Therefore I thought that it would be nice to have a Table-Object, similiar to the Column-Object, which just holds the data. I also used a seperat dict (
self.data) instead ofself.__dict__, which again makes its easier to seriale and compare the objects based on the data.What do you think?
Thanks in advance
Björn