Allow users to define ctl_connection_settings and the option to fail when table information is unavailable #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k changes in a given cluster rather than default, force failure on failure to get TableMetadata
…f BinLogStreamReader, added charset for ctl_connection_settings
…it being a generic exception
Merge noplay's changes in to optional_ctl_connection_settings, add test for metadata unavailable error
|
By the way, if you want me to squash these commits, let me know. |
baloo
reviewed
Nov 6, 2016
| @@ -37,6 +37,9 @@ _build | |||
| *.xml | |||
| *.iml | |||
|
|
|||
| # Temp vim .swp s | |||
| *.swp | |||
There was a problem hiding this comment.
Pro tip: this should go in your global ignore file instead. Defaults to: $HOME/.config/git/ignore
This is not blocking for merge though.
| self.__connection_settings = connection_settings | ||
| self.__connection_settings["charset"] = "utf8" | ||
| if not connection_settings.get("charset"): | ||
| self.__connection_settings["charset"] = "utf8" |
There was a problem hiding this comment.
self.__connection_settings.setdefault("charset", "utf8")
|
I agree the change sound good. If you can add a test for ctl_connection_settings it will be perfect |
…nore, made default charset applying simpler, fixed travis for new mysql servers necessary for ctl_connection_settings test (including removing usage of mysql sandbox in mysql57 tests to bring it in line with what's going on in mysql56 tests)
|
Tests are done and working now (sorry for commit spam earlier, they're all squashed now) |
|
\o/ I started looking at implementing the tests myself, and I have to admit I became quite lazy when looking at the travis mess. Thank you very much for your work. All looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #56
To allow users to create their own secondary database that tracks schema changes if they want to ensure they will always have table_metadata (in case of a dropped table before a message can be picked up). It also adds an (optional) parameter that makes the BinLogStreamReader raise an exception if there is an issue getting schema information for a query. This allows the library to stay low-level while giving users the option of alleviating this issue.