Partial fix for dropped columns blowing up replication #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… binlog with past events
Mitigates following errror:
File "/usr/local/lib/python2.7/dist-packages/pymysqlreplication/binlogstream.py", line 262, in fetchone
self.__freeze_schema)
File "/usr/local/lib/python2.7/dist-packages/pymysqlreplication/packet.py", line 98, in __init__
freeze_schema = freeze_schema)
File "/usr/local/lib/python2.7/dist-packages/pymysqlreplication/row_event.py", line 550, in __init__
column_schema = self.column_schemas[i]
IndexError: list index out of range
This is just a superficial patch. It does not address deeper issue at hand, which is that pymysqlreplication
has no good way of handling RowEvents containing columns which have been dropped prior to pymsqlreplication
start. The problem is always relying on current version of information_schema even though dealing with events
that might be several versions in the past.
|
I've also created issue this and the underlying problem: #118 |
|
Do you think it's possible to write a test for this ? I'm not sure |
|
@noplay I've added unittest. Verified that it fails on your master. |
|
Great thanks ! |
julien-duponchelle
added a commit
that referenced
this pull request
Jun 19, 2015
Partial fix for dropped columns blowing up replication
vartec
pushed a commit
to vartec/python-mysql-replication
that referenced
this pull request
Jun 19, 2015
…lien-duponchelle#117 does not fix that one
vartec
pushed a commit
to vartec/python-mysql-replication
that referenced
this pull request
Jun 19, 2015
…lien-duponchelle#117 does not fix that one
vartec
pushed a commit
to vartec/python-mysql-replication
that referenced
this pull request
Jun 19, 2015
…lien-duponchelle#117 does not fix that one
vartec
pushed a commit
to vartec/python-mysql-replication
that referenced
this pull request
Jun 19, 2015
…lien-duponchelle#117 does not fix that one
vartec
pushed a commit
to vartec/python-mysql-replication
that referenced
this pull request
Jun 20, 2015
…lien-duponchelle#117 does not fix that one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for dropped columns blowing up replication when replaying binlog with past events
Mitigates following error:
This is just a superficial patch. It does not address deeper issue at hand, which is that
pymysqlreplicationhas no good way of handlingRowEvents containing columns which have been dropped prior topymsqlreplicationstart. The problem is always relying on current version ofinformation_schemaeven though dealing with events that might be several versions in the past.