Skip to content

Add regression for #991 #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2016
Merged

Add regression for #991 #992

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions tests/lib/rules/prop-types.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1398,6 +1398,23 @@ ruleTester.run('prop-types', rule, {
'}'
].join('\n'),
parser: 'babel-eslint'
}, {
code: [
'class Hello extends React.Component {',
' async onSelect({ name }) {',
' return null;',
' }',
' render() {',
' return <Greeting onSelect={this.onSelect} />;',
' }',
'}'
].join('\n'),
parserOptions: {
ecmaVersion: 8,
ecmaFeatures: {
jsx: true
}
}
}
],

Expand Down Expand Up @@ -2530,6 +2547,21 @@ ruleTester.run('prop-types', rule, {
errors: [
{message: '\'firstname\' is missing in props validation'}
]
}, {
code: [
'class Hello extends React.Component {',
' onSelect = async ({ name }) => {',
' return this.props.foo;',
' }',
' render() {',
' return <Greeting onSelect={this.onSelect} />;',
' }',
'}'
].join('\n'),
parser: 'babel-eslint',
errors: [
{message: '\'foo\' is missing in props validation'}
]
}
]
});