Fix wrap-multilines rule #728
Conversation
|
Thanks! Can you add a test that would have caught this bug? |
|
@ljharb I thought about adding a test but it is a deprecated rule that uses jsx-wrap-multilines rule under the hood. So I'm not sure how to test it properly. Should we just copy this test https://github.com/yannickcr/eslint-plugin-react/blob/master/tests/lib/rules/jsx-wrap-multilines.js? Or should we create separate test with a single random valid code snippet to just test that it works? |
|
I think that as long as we're keeping the deprecated test we should keep the deprecated test file - so yeah, just duplicating https://github.com/yannickcr/eslint-plugin-react/blob/master/tests/lib/rules/jsx-wrap-multilines.js is probably good. |
Wrap multilines was broken after switching to new eslint rule format. Also in this commit wrap-multilines was aligned with jsx-wrap-multilines: "fixed: 'code'" was added to its meta.
akozhemiakin
force-pushed
the
fix-wrap-multilines
branch
from
ffab8c1 to
99f5eac
Compare
|
Yeah, it is definitely a good approach to duplicate that test file :) It revealed another bug with missing meta property (fixable: 'code'). I fixed it and added the test. |
|
Thanks! |
This reverts commit 2f7a462 per 2f7a462#commitcomment-18463332. It also fixes a bug in `no-comment-textnodes` related to #728, and restores the tests for `no-comment-textnodes` from #689.
Wrap multilines was broken after switching to new eslint rule format.