Fix jsx-no-bind reporting errors on render functions #676
Conversation
| var propName = require('jsx-ast-utils/propName'); | ||
|
|
||
| // ----------------------------------------------------------------------------- | ||
| // Rule Definition | ||
| // ----------------------------------------------------------------------------- | ||
|
|
||
| module.exports = function(context) { | ||
| function renderReturnsJSX(node, utils) { |
There was a problem hiding this comment.
this seems like it might be common behavior that all the rules could use - and that some may already have implemented?
There was a problem hiding this comment.
I agree. Sounds like we should move it to the utils provided by the Components utility? What should it be named? There is already a isReturningJSX that does the bulk of this work but this deals with finding the ReturnStatement
There was a problem hiding this comment.
Is there a reason that isReturningJSX isn't already checking for a return statement?
There was a problem hiding this comment.
It currently expects a ReturnStatement or a ArrowFunctionExpression to be passed in.
There was a problem hiding this comment.
We could make the default for the case statement to find a return the ReturnStatement
There was a problem hiding this comment.
I think it makes sense for "is returning JSX" to accept any kind of function, and it should be able to accurately return a boolean.
There was a problem hiding this comment.
Updated it to make isReturningJSX to handle more nodes.
petersendidit
force-pushed
the
jsx-no-bind-rendermethods
branch
from
be3d26a to
025305e
Compare
| { | ||
| code: [ | ||
| 'const foo = {', | ||
| ' render: function() {', |
There was a problem hiding this comment.
can we also cover the render() { case?
JSX (Fixes jsx-eslint#663) Enhance isReturningJSX to handle more node types
petersendidit
force-pushed
the
jsx-no-bind-rendermethods
branch
from
025305e to
cf0ff04
Compare
|
Merged, thanks! |
Fix jsx-no-bind reporting errors on render functions that don't return JSX (Fixes #663)