Fix no-comment-textnodes incorrectly catching urls (fixes #664) #665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petersendidit
force-pushed
the
no-comment-textnodes-url-fix
branch
from
e5c6fea to
9b37d2d
Compare
|
LGTM. Test failures appear to be related to eslint 3 dropping pre-node-4 support. |
|
@petersendidit if you rebase on latest master, your tests should pass. |
petersendidit
force-pushed
the
no-comment-textnodes-url-fix
branch
from
9b37d2d to
3354ca3
Compare
petersendidit
force-pushed
the
no-comment-textnodes-url-fix
branch
from
3354ca3 to
554eceb
Compare
| @@ -19,7 +19,7 @@ module.exports = function(context) { | |||
|
|
|||
| return { | |||
| Literal: function(node) { | |||
| if (/\s*\/(\/|\*)/.test(node.value)) { | |||
| if (/^\s*\/(\/|\*)/m.test(node.value)) { | |||
There was a problem hiding this comment.
since this is just testing the start of a quasi-comment, does it need the "m"?
There was a problem hiding this comment.
Without the m modifier things like this would fail:
<div>
asdjfl
/* invalid */
foo
</div>There was a problem hiding this comment.
ah right, i'm assuming the text node will be split up by lines, and that's not likely to be the case.
Could we add your example as a test, to prevent a regression?
There was a problem hiding this comment.
There was a problem hiding this comment.
ah, understood, thanks for clarifying :-)
|
@yannickcr ping :-) |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #664.